Remove the Keystore API #3657
Merged
Remove the Keystore API #3657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
requested review from
marun and
meaghanfitzgerald
as code owners
StephenButtolph
commented
Jan 17, 2025
There was a problem hiding this comment.
@meaghanfitzgerald Is there a change that needs to be made to the docs repo with the removal of this file?
There was a problem hiding this comment.
The keystore API has been marked deprecated in the docs since March 2023. Once this PR is merged, we should include "[DEPRECATED]" in the title and sidebar, and remove the documentation entirely after about 4-6 weeks. cc: @owenwahlgren @ashucoder9
There was a problem hiding this comment.
link to docs: https://docs.avax.network/api-reference/keystore-api
darioush
approved these changes
Jan 17, 2025
marun
approved these changes
Jan 17, 2025
richardpringle
approved these changes
Jan 17, 2025
|
cc: @Andyvargtz |
meaghanfitzgerald
approved these changes
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
The Keystore API has been deprecated for almost 2 years. Since Etna was recently activated, now is the ideal time to remove it.
How this works
This PR removes all code related to the keystore.
How this was tested
CI
Need to be documented in RELEASES.md?
Yes.