Fix json parsing of GetValidatorsAtArgs #3551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marun
approved these changes
Nov 16, 2024
StephenButtolph
approved these changes
Nov 18, 2024
StephenButtolph
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Bugfix for a bug introduced in #3531 for the new
"proposed"flag toplatform.getValidatorsAtHow this works
Encoded bytes when passed in to the
UnmarshalJSONcontain extra quotes and escape characters. We need to unmarshal the string before comparison instead of doing it directly.How this was tested
Adds new test
TestGetValidatorsAtArgsMarshallingthat fails before this fix and succeeds nowNeed to be documented in RELEASES.md?
no (bugfix for already documented feature)