Remove P-chain txsmock package #3528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
added
testing
marun
approved these changes
Nov 7, 2024
aaronbuchwald
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Currently, many of the
verifiertests in the P-chain require mocking dependencies. These tests are brittle (and often incorrect).This PR fixes
TestVerifierVisitAtomicBlock. Previously the test was executing in theupgradetest.ApricotPhasePost6environment. However,ApricotAtomicBlocks were actually disabled inupgradetest.ApricotPhase5. This test was completely broken and just happened to be passing.Additionally, this test introduces significantly stronger testing for the actual behavior of the code by asserting the full
blockStateis equal (rather than verifying a subset of the fields).How this works
This PR refactors:
TestVerifierVisitProposalBlockTestVerifierVisitAtomicBlockTestVerifierVisitStandardBlockTestVerifierVisitStandardBlockWithDuplicateInputs(this test is merged withTestVerifierVisitStandardBlockdue to the extent of duplicated code).The newly refactored tests do not utilize any mocks.
How this was tested
CI.
Need to be documented in RELEASES.md?
No.