ACP-103: Document and update genesis test fee configs #3520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yacovm
reviewed
Nov 5, 2024
genesis/genesis_local.go
Outdated
| MaxPerSecond: 250_000, | ||
| TargetPerSecond: 125_000, // Target block size ~125KB | ||
| MinPrice: 1, | ||
| // ExcessConversionConstant = (Capacity - Target) * NumberOfSecondsPerDoubling / ln(2) |
There was a problem hiding this comment.
(1000000 - 125000) * (30 / ln(2)) is not 5.4 million.
There was a problem hiding this comment.
Sorry, was supposed to read as Capacity (per second) - Target (per second) (like in the SoV calculations below).
Updated to use the exact names in the config.
There was a problem hiding this comment.
(The calculation is: (250_000 - 125_000) * (30 / ln(2))
yacovm
approved these changes
Nov 5, 2024
geoff-vball
approved these changes
Nov 5, 2024
darioush
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
While these are not the final values, this change documents the meanings of each parameter and makes the default values (used in our tests) more useful.
Currently, It is possible for the tx fee to increase instantaneously by a factor of
e^200. Which is just not suitable for testing.How this works
Significantly increases the
MaxPerSecond,TargetPerSecond, andExcessConversionConstantto produce more stable fees (using the sameMaxCapacity).One unit test needed to be modified because it didn't properly account for
MaxCapacity.How this was tested
N/A
Need to be documented in RELEASES.md?
No.