Use subnet public key diffs after Etna is activated #3502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceyonur
reviewed
Oct 29, 2024
Comment on lines
+2529
to
+2531
| if !s.upgrades.IsEtnaActivated(s.persistedTimestamp) && s.upgrades.IsEtnaActivated(s.timestamp) { | ||
| if err := database.PutUInt64(s.singletonDB, EtnaHeightKey, height); err != nil { | ||
| return fmt.Errorf("failed to write etna height: %w", err) |
There was a problem hiding this comment.
nit: should we check if we have already written it? In case where we can call the commit without advancing the chain (like disconnect?).
There was a problem hiding this comment.
persistedTimestamp is updated to equal timestamp immediately after this, and both of them are monotonically increasing. So this condition can only happen once.
marun
approved these changes
Oct 29, 2024
…va-labs/avalanchego into use-subnet-public-key-diffs-after-etna
michaelkaplan13
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
When existing networks upgrade from Pre-Etna to Post-Etna, the nodes in that network are only guaranteed to have populated the public key diffs for subnets after the transition.
This means that we can only safely use this new index after Etna has been activated.
However, we must use the new index after Etna is activated because the public keys are not guaranteed to be inherited from the primary network after Etna.
How this works
Uses the new public key diffs after Etna is activated (but not before).
How this was tested
Added multiple new unit tests.
Need to be documented in RELEASES.md?
There are no user facing changes.