Add getProposedValidators RPC method #3497
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marun
reviewed
Oct 24, 2024
marun
reviewed
Oct 25, 2024
…hego into get-proposed-validators
marun
reviewed
Oct 25, 2024
marun
approved these changes
Oct 25, 2024
iansuvak
reviewed
Oct 28, 2024
Co-authored-by: Ian Suvak <[email protected]> Signed-off-by: cam-schultz <[email protected]>
| @@ -120,6 +120,13 @@ type Client interface { | |||
| height uint64, | |||
| options ...rpc.Option, | |||
| ) (map[ids.NodeID]*validators.GetValidatorOutput, error) | |||
| // GetProposedValidators returns the weights of the validator set of a provided | |||
| // subnet at the proposer's height. | |||
There was a problem hiding this comment.
Suggested change
| // subnet at the proposer's height. | |
| // subnet at this node's current proposed height. |
Technically the proposed height is determined on a per-node basis, and the node serving the RPC request likely isn't the same as the proposer of the next block.
|
Closing in favor of #3531 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Exposes via RPC the validators at the proposer VM height used by the inner VM to verify blocks. Useful for gathering ICM signatures from the validators at the height used to verify the block, as specified in ACP-151
How this works
Adds
GetProposedValidatorswhich fetches the validators atState.GetMinimumHeight. Other than that, the implementation is identical toGetValidatorsAtHow this was tested
CI
Need to be documented in RELEASES.md?
Yes