Allow non primary network validators to request all peers #3491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marun
reviewed
Oct 24, 2024
marun
approved these changes
Oct 24, 2024
This was referenced Oct 28, 2024
iansuvak
approved these changes
Nov 13, 2024
StephenButtolph
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Network.Peerscurrently only allows primary network validators to request the list of all peers across all L1's. This is primarily a bootstrapping optimization to prevent large numbers of peers for changing validator sets from being circulated as the P-Chain is synced.Removing this check would simplify peer discovery for non-validators that need p2p connections with arbitrary nodes. One example is ICM signature aggregators - with the current semantics, they are only able to request peers for tracked subnets, which is capped at 16.
How this works
Removes the above restriction.
How this was tested
CI, added unit test