ACP-77: Write subnet public key diffs to state #3487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
commented
Oct 22, 2024
| @@ -271,7 +272,7 @@ func (m *manager) makePrimaryNetworkValidatorSet( | |||
| validatorSet, | |||
| currentHeight, | |||
| lastDiffHeight, | |||
| constants.PlatformChainID, | |||
There was a problem hiding this comment.
This was the wrong constant before - but they happen to have the same value... So not an issue
…s/avalanchego into populate-subnet-public-key-diffs
StephenButtolph
commented
Oct 22, 2024
marun
reviewed
Oct 24, 2024
There was a problem hiding this comment.
Not the fault of this PR, but I found the testing changes quite painful to review. Ideally there would be comprehensive tests of low-level behavior and then higher-level testing could be less rigorous (only validating behavior not covered by the lower-level tests), but both of the tests that were modified seem a bit unfocused to me.
StephenButtolph
changed the base branch from
master
to
update-state-staker-tests
marun
approved these changes
Oct 24, 2024
ceyonur
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Factored out of #3388.
After ACP-77, L1 validators specify their own BLS public keys. This means that we can no longer assume that the public keys are inherited from a primary network validator.
How this works
Previously public key diffs were only written for primary network validators.
Now when a subnet validator is added or removed, a subnet specific key diff is written.
Additionally, non-nil public keys were only held in the validator set for the primary network validators. The state now exposes the public keys on all subnets.
How this was tested