Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACP-77: Implement IncreaseBalanceTx #3429

Merged
merged 774 commits into from
Nov 13, 2024
Merged

ACP-77: Implement IncreaseBalanceTx #3429

merged 774 commits into from
Nov 13, 2024

Conversation

StephenButtolph
Copy link
Contributor

@StephenButtolph StephenButtolph commented Sep 30, 2024 •
edited
Loading

Why this should be merged

This PR introduces the IncreaseBalanceTx defined by ACP-77.

This PR includes:

  • IncreaseBalanceTx serialization definition
  • IncreaseBalanceTx building and wallet support
  • (Basic) complexity calculations for IncreaseBalanceTx
  • Execution logic and rules for IncreaseBalanceTx
  • Example usage of IncreaseBalanceTx

This PR does not include the finalized ACP-103 complexity values for IncreaseBalanceTx

How this works

This PR adds the new IncreaseBalanceTx type and implements all the required visitors.

How this was tested

  • Added unit tests for all new code
  • Added e2e test for new transaction type

@StephenButtolph StephenButtolph self-assigned this Oct 4, 2024
@StephenButtolph StephenButtolph added this to the v1.12.0-prerelease milestone Oct 4, 2024
@StephenButtolph
nit
ef29548
@StephenButtolph
test subnetIDNodeIDDB
a77fb3c
@StephenButtolph
fix comments
ce05dc8
@StephenButtolph
nit
3d04cef
@StephenButtolph
nit
dc35645
@StephenButtolph
Reduce diff
d472a9f
@StephenButtolph
add comment
34ba29b
@StephenButtolph
reduce diff
97029aa
@StephenButtolph
Add NumSubnets to the validator manager interface
dbeee70
@StephenButtolph
merged
729ded5
@StephenButtolph
add comment
3621e53
@StephenButtolph
merged
de2be9f
@StephenButtolph
Delete empty entries
92a2277
@StephenButtolph
simplify state futher
6375aa2
@StephenButtolph
nit
aedff15
@StephenButtolph
nit
1ac030a
@StephenButtolph
Add caching
9e0d7d5
@StephenButtolph
nit
9993b05
@StephenButtolph
nit
547d426
@StephenButtolph
Add TODOs
6bcc0ea
@StephenButtolph
Merge branch 'master' into implement-acp-77-sov-validators-state
6065604
@StephenButtolph
Add config changes to readme
a7792c7
@StephenButtolph
Merge branch 'implement-acp-77-sov-validators-state' of github.com:av…
39b961b 
…a-labs/avalanchego into implement-acp-77-sov-validators-state
@StephenButtolph
Improve doc for PutSubnetOnlyValidator
4723c46
@StephenButtolph
Merge branch 'master' into implement-acp-77-sov-validators-state
46c4889
@StephenButtolph
merged
a576cd1
@StephenButtolph
Merge branch 'implement-acp-77-warp-signing' into implement-acp-77-in…
1fd8ba4 
…crease-balance-tx
@StephenButtolph
merge
58939b2
@StephenButtolph
Rename error to be more generic
039d539
@StephenButtolph
Merge branch 'rename-error' into add-get-subnet-only-validator-api
a14dc90
@StephenButtolph
Merge branch 'add-get-subnet-only-validator-api' into add-validation-…
06ce053 
…id-to-wallet
@StephenButtolph
Merge branch 'add-validation-id-to-wallet' into implement-acp-77-warp…
c03ad3b 
…-verification
@StephenButtolph
Merge branch 'implement-acp-77-warp-verification' into implement-acp-…
75f94bf 
…77-warp-signing
@StephenButtolph
Merge branch 'implement-acp-77-warp-signing' into implement-acp-77-in…
af868ab 
…crease-balance-tx
@StephenButtolph
Add concurrent reads
e485bd0
@StephenButtolph
Merge branch 'implement-acp-77-warp-signing' into implement-acp-77-in…
3430967 
…crease-balance-tx
@StephenButtolph
Fix flaky test
2092848
@StephenButtolph
Merge branch 'master' into add-get-subnet-only-validator-api
54f58a8
@StephenButtolph
Merge branch 'master' into add-get-subnet-only-validator-api
8806a57
@StephenButtolph
Address PR comments
d9b04ba
@StephenButtolph
Merge branch 'add-get-subnet-only-validator-api' into add-validation-…
cfc0432 
…id-to-wallet
@StephenButtolph
Merge branch 'master' into add-validation-id-to-wallet
137ce85
@StephenButtolph
Merge branch 'add-validation-id-to-wallet' into implement-acp-77-warp…
2fc07b3 
…-verification
@StephenButtolph
Merge branch 'master' into implement-acp-77-warp-verification
52e04ff
@StephenButtolph
Merge branch 'implement-acp-77-warp-verification' into implement-acp-…
7953623 
…77-warp-signing
@StephenButtolph
Merge branch 'implement-acp-77-warp-signing' into implement-acp-77-in…
3a6726c 
…crease-balance-tx
@StephenButtolph
Merge branch 'master' into implement-acp-77-warp-signing
8afb146
@StephenButtolph
Merge branch 'implement-acp-77-warp-signing' into implement-acp-77-in…
206a059 
…crease-balance-tx
Base automatically changed from implement-acp-77-warp-signing to master November 13, 2024 16:50
@StephenButtolph StephenButtolph added this pull request to the merge queue Nov 13, 2024
Merged via the queue into master with commit 4c19989 Nov 13, 2024
23 checks passed
@StephenButtolph StephenButtolph deleted the implement-acp-77-increase-balance-tx branch November 13, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darioush darioush darioush approved these changes

@ceyonur ceyonur ceyonur approved these changes

@yacovm yacovm yacovm approved these changes

@marun marun marun approved these changes

@joshua-kim joshua-kim Awaiting requested review from joshua-kim

Assignees

@StephenButtolph StephenButtolph

Labels
acp77
Projects
Platform Engineering Group
Archived in project
Milestone
v1.11.13
Development

Successfully merging this pull request may close these issues.
5 participants
@StephenButtolph @marun @darioush @yacovm @ceyonur