Add P-chain fee APIs #3286
Merged
Add P-chain fee APIs #3286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
dhrubabasu
reviewed
Aug 10, 2024
dhrubabasu
approved these changes
Aug 15, 2024
marun
approved these changes
Aug 15, 2024
ARR4N
approved these changes
Aug 15, 2024
| defer s.vm.ctx.Lock.Unlock() | ||
|
|
||
| reply.State = s.vm.state.GetFeeState() | ||
| reply.Price = s.vm.DynamicFeeConfig.MinGasPrice.MulExp( |
There was a problem hiding this comment.
Is there shared code that performs this calculation? I'm guessing the price is used somewhere internally, and this is at risk of diverging.
There was a problem hiding this comment.
I'm not sure how better to share this... This function takes in 3 params to calculate the price... Any helper would also take in 3 params and just call this function... No?
There was a problem hiding this comment.
Will change this in a breakout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This PR:
How this works
Adds APIs to the service + client.
How this was tested