Remove unused error from fee calculator creation #3245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
requested review from
abi87,
danlaine and
dhrubabasu
as code owners
StephenButtolph
commented
Jul 29, 2024
Comment on lines
+78
to
81
| func PickFeeCalculator(cfg *config.Config, state Chain) fee.Calculator { | ||
| timestamp := state.GetTimestamp() | ||
| return fee.NewStaticCalculator(cfg.StaticFeeConfig, cfg.UpgradeConfig, timestamp), nil | ||
| return fee.NewStaticCalculator(cfg.StaticFeeConfig, cfg.UpgradeConfig, timestamp) | ||
| } |
There was a problem hiding this comment.
This is the actual change
dhrubabasu
approved these changes
Jul 29, 2024
yacovm
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This function doesn't currently (and doesn't seem like it will need to in the future) return any errors.
How this works
Deletes code.
How this was tested