Rename Transitive snowman to Engine snowman #3244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the package snow/engine/snowman, the engine is called Transitive, and resides in transitive.go. while in the package snow/engine/avalanche it's respectively Engine and engine.go. Moreover, in the tests of snow/engine/snowman/, the bespoken object is referred to as engine. I therefore rename the transitive to engine to better fit the rest of the code. Signed-off-by: Yacov Manevich <[email protected]>
StephenButtolph
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
In the package snow/engine/snowman, the engine is called Transitive, and resides in transitive.go. while in the package snow/engine/avalanche it's respectively Engine and engine.go.
Moreover, in the tests of snow/engine/snowman/, the bespoken object is referred to as engine.
I therefore rename the transitive to engine to better fit the rest of the code.
How this works
Just a file and struct renaming
How this was tested
If the unit tests pass, this should be good to go.