Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup wallet tests #3230

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Cleanup wallet tests #3230

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e00705
Cleanup wallet tests
StephenButtolph Jul 24, 2024
d99f696
nit
StephenButtolph Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
282 changes: 165 additions & 117 deletions wallet/chain/p/builder_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ func TestBaseTx(t *testing.T) {
builder = builder.New(set.Of(utxoAddr), testContext, backend)

// data to build the transaction
outputsToMove = []*avax.TransferableOutput{{
outputToMove = &avax.TransferableOutput{
Asset: avax.Asset{ID: avaxAssetID},
Out: &secp256k1fx.TransferOutput{
Amt: 7 * units.Avax,
Expand All @@ -76,22 +76,25 @@ func TestBaseTx(t *testing.T) {
Addrs: []ids.ShortID{utxoAddr},
},
},
}}
}
)

utx, err := builder.NewBaseTx(outputsToMove)
utx, err := builder.NewBaseTx([]*avax.TransferableOutput{outputToMove})
require.NoError(err)

// check UTXOs selection and fee financing
ins := utx.Ins
outs := utx.Outs
require.Len(ins, 2)
require.Len(outs, 2)
// check that the output is included in the transaction
require.Contains(utx.Outs, outputToMove)

expectedConsumed := testContext.BaseTxFee + outputsToMove[0].Out.Amount()
consumed := ins[0].In.Amount() + ins[1].In.Amount() - outs[0].Out.Amount()
require.Equal(expectedConsumed, consumed)
require.Equal(outputsToMove[0], outs[1])
// check fee calculation
require.Equal(
marun marked this conversation as resolved.
Show resolved Hide resolved
addAmounts(
addOutputAmounts(utx.Outs),
map[ids.ID]uint64{
avaxAssetID: testContext.BaseTxFee,
},
),
addInputAmounts(utx.Ins),
)
}

func TestAddSubnetValidatorTx(t *testing.T) {
Expand Down Expand Up @@ -140,15 +143,16 @@ func TestAddSubnetValidatorTx(t *testing.T) {
utx, err := builder.NewAddSubnetValidatorTx(subnetValidator)
require.NoError(err)

// check UTXOs selection and fee financing
ins := utx.Ins
outs := utx.Outs
require.Len(ins, 2)
require.Len(outs, 1)

expectedConsumed := testContext.AddSubnetValidatorFee
consumed := ins[0].In.Amount() + ins[1].In.Amount() - outs[0].Out.Amount()
require.Equal(expectedConsumed, consumed)
// check fee calculation
require.Equal(
addAmounts(
addOutputAmounts(utx.Outs),
map[ids.ID]uint64{
avaxAssetID: testContext.AddSubnetValidatorFee,
},
),
addInputAmounts(utx.Ins),
)
}

func TestRemoveSubnetValidatorTx(t *testing.T) {
Expand Down Expand Up @@ -191,15 +195,16 @@ func TestRemoveSubnetValidatorTx(t *testing.T) {
)
require.NoError(err)

// check UTXOs selection and fee financing
ins := utx.Ins
outs := utx.Outs
require.Len(ins, 1)
require.Len(outs, 1)

expectedConsumed := testContext.BaseTxFee
consumed := ins[0].In.Amount() - outs[0].Out.Amount()
require.Equal(expectedConsumed, consumed)
// check fee calculation
require.Equal(
addAmounts(
addOutputAmounts(utx.Outs),
map[ids.ID]uint64{
avaxAssetID: testContext.BaseTxFee,
},
),
addInputAmounts(utx.Ins),
)
}

func TestCreateChainTx(t *testing.T) {
Expand Down Expand Up @@ -250,15 +255,16 @@ func TestCreateChainTx(t *testing.T) {
)
require.NoError(err)

// check UTXOs selection and fee financing
ins := utx.Ins
outs := utx.Outs
require.Len(ins, 1)
require.Len(outs, 1)

expectedConsumed := testContext.CreateBlockchainTxFee
consumed := ins[0].In.Amount() - outs[0].Out.Amount()
require.Equal(expectedConsumed, consumed)
// check fee calculation
require.Equal(
addAmounts(
addOutputAmounts(utx.Outs),
map[ids.ID]uint64{
avaxAssetID: testContext.CreateBlockchainTxFee,
},
),
addInputAmounts(utx.Ins),
)
}

func TestCreateSubnetTx(t *testing.T) {
Expand Down Expand Up @@ -298,15 +304,16 @@ func TestCreateSubnetTx(t *testing.T) {
utx, err := builder.NewCreateSubnetTx(subnetOwner)
require.NoError(err)

// check UTXOs selection and fee financing
ins := utx.Ins
outs := utx.Outs
require.Len(ins, 1)
require.Len(outs, 1)

expectedConsumed := testContext.CreateSubnetTxFee
consumed := ins[0].In.Amount() - outs[0].Out.Amount()
require.Equal(expectedConsumed, consumed)
// check fee calculation
require.Equal(
addAmounts(
addOutputAmounts(utx.Outs),
map[ids.ID]uint64{
avaxAssetID: testContext.CreateSubnetTxFee,
},
),
addInputAmounts(utx.Ins),
)
}

func TestTransferSubnetOwnershipTx(t *testing.T) {
Expand Down Expand Up @@ -349,15 +356,16 @@ func TestTransferSubnetOwnershipTx(t *testing.T) {
)
require.NoError(err)

// check UTXOs selection and fee financing
ins := utx.Ins
outs := utx.Outs
require.Len(ins, 1)
require.Len(outs, 1)

expectedConsumed := testContext.BaseTxFee
consumed := ins[0].In.Amount() - outs[0].Out.Amount()
require.Equal(expectedConsumed, consumed)
// check fee calculation
require.Equal(
addAmounts(
addOutputAmounts(utx.Outs),
map[ids.ID]uint64{
avaxAssetID: testContext.BaseTxFee,
},
),
addInputAmounts(utx.Ins),
)
}

func TestImportTx(t *testing.T) {
Expand Down Expand Up @@ -397,17 +405,18 @@ func TestImportTx(t *testing.T) {
)
require.NoError(err)

// check UTXOs selection and fee financing
ins := utx.Ins
outs := utx.Outs
importedIns := utx.ImportedInputs
require.Empty(ins) // we spend the imported input (at least partially)
require.Len(importedIns, 1)
require.Len(outs, 1)

expectedConsumed := testContext.BaseTxFee
consumed := importedIns[0].In.Amount() - outs[0].Out.Amount()
require.Equal(expectedConsumed, consumed)
require.Empty(utx.Ins) // we spend the imported input (at least partially)

// check fee calculation
require.Equal(
addAmounts(
addOutputAmounts(utx.Outs),
map[ids.ID]uint64{
avaxAssetID: testContext.BaseTxFee,
},
),
addInputAmounts(utx.Ins, utx.ImportedInputs),
)
}

func TestExportTx(t *testing.T) {
Expand Down Expand Up @@ -447,16 +456,18 @@ func TestExportTx(t *testing.T) {
)
require.NoError(err)

// check UTXOs selection and fee financing
ins := utx.Ins
outs := utx.Outs
require.Len(ins, 2)
require.Len(outs, 1)

expectedConsumed := testContext.BaseTxFee + exportedOutputs[0].Out.Amount()
consumed := ins[0].In.Amount() + ins[1].In.Amount() - outs[0].Out.Amount()
require.Equal(expectedConsumed, consumed)
require.Equal(utx.ExportedOutputs, exportedOutputs)

// check fee calculation
require.Equal(
addAmounts(
addOutputAmounts(utx.Outs, utx.ExportedOutputs),
map[ids.ID]uint64{
avaxAssetID: testContext.BaseTxFee,
},
),
addInputAmounts(utx.Ins),
)
}

func TestTransformSubnetTx(t *testing.T) {
Expand Down Expand Up @@ -515,18 +526,17 @@ func TestTransformSubnetTx(t *testing.T) {
)
require.NoError(err)

// check UTXOs selection and fee financing
ins := utx.Ins
outs := utx.Outs
require.Len(ins, 2)
require.Len(outs, 2)

expectedConsumedSubnetAsset := maxSupply - initialSupply
consumedSubnetAsset := ins[0].In.Amount() - outs[1].Out.Amount()
require.Equal(expectedConsumedSubnetAsset, consumedSubnetAsset)
expectedConsumed := testContext.TransformSubnetTxFee
consumed := ins[1].In.Amount() - outs[0].Out.Amount()
require.Equal(expectedConsumed, consumed)
// check fee calculation
require.Equal(
addAmounts(
addOutputAmounts(utx.Outs),
map[ids.ID]uint64{
avaxAssetID: testContext.TransformSubnetTxFee,
subnetAssetID: maxSupply - initialSupply,
},
),
addInputAmounts(utx.Ins),
)
}

func TestAddPermissionlessValidatorTx(t *testing.T) {
Expand Down Expand Up @@ -583,20 +593,24 @@ func TestAddPermissionlessValidatorTx(t *testing.T) {
)
require.NoError(err)

// check UTXOs selection and fee financing
ins := utx.Ins
staked := utx.StakeOuts
outs := utx.Outs
require.Len(ins, 4)
require.Len(staked, 2)
require.Len(outs, 2)

expectedConsumedSubnetAsset := utx.Validator.Weight()
consumedSubnetAsset := staked[0].Out.Amount() + staked[1].Out.Amount()
require.Equal(expectedConsumedSubnetAsset, consumedSubnetAsset)
expectedConsumed := testContext.AddPrimaryNetworkValidatorFee
consumed := ins[1].In.Amount() + ins[3].In.Amount() - outs[0].Out.Amount()
require.Equal(expectedConsumed, consumed)
// check stake amount
require.Equal(
map[ids.ID]uint64{
avaxAssetID: 2 * units.Avax,
},
addOutputAmounts(utx.StakeOuts),
)

// check fee calculation
require.Equal(
addAmounts(
addOutputAmounts(utx.Outs, utx.StakeOuts),
map[ids.ID]uint64{
avaxAssetID: testContext.AddPrimaryNetworkValidatorFee,
},
),
addInputAmounts(utx.Ins),
)
}

func TestAddPermissionlessDelegatorTx(t *testing.T) {
Expand Down Expand Up @@ -641,20 +655,24 @@ func TestAddPermissionlessDelegatorTx(t *testing.T) {
)
require.NoError(err)

// check UTXOs selection and fee financing
ins := utx.Ins
staked := utx.StakeOuts
outs := utx.Outs
require.Len(ins, 4)
require.Len(staked, 2)
require.Len(outs, 2)

expectedConsumedSubnetAsset := utx.Validator.Weight()
consumedSubnetAsset := staked[0].Out.Amount() + staked[1].Out.Amount()
require.Equal(expectedConsumedSubnetAsset, consumedSubnetAsset)
expectedConsumed := testContext.AddPrimaryNetworkDelegatorFee
consumed := ins[1].In.Amount() + ins[3].In.Amount() - outs[0].Out.Amount()
require.Equal(expectedConsumed, consumed)
// check stake amount
require.Equal(
map[ids.ID]uint64{
avaxAssetID: 2 * units.Avax,
},
addOutputAmounts(utx.StakeOuts),
)

// check fee calculation
require.Equal(
addAmounts(
addOutputAmounts(utx.Outs, utx.StakeOuts),
map[ids.ID]uint64{
avaxAssetID: testContext.AddPrimaryNetworkDelegatorFee,
},
),
addInputAmounts(utx.Ins),
)
}

func makeTestUTXOs(utxosKey *secp256k1.PrivateKey) []*avax.UTXO {
Expand Down Expand Up @@ -745,3 +763,33 @@ func makeTestUTXOs(utxosKey *secp256k1.PrivateKey) []*avax.UTXO {
},
}
}

func addAmounts(allAmounts ...map[ids.ID]uint64) map[ids.ID]uint64 {
amounts := make(map[ids.ID]uint64)
for _, amountsToAdd := range allAmounts {
for assetID, amount := range amountsToAdd {
amounts[assetID] += amount
}
}
return amounts
}

func addInputAmounts(inputSlices ...[]*avax.TransferableInput) map[ids.ID]uint64 {
consumed := make(map[ids.ID]uint64)
for _, inputs := range inputSlices {
for _, in := range inputs {
consumed[in.AssetID()] += in.In.Amount()
}
}
return consumed
}

func addOutputAmounts(outputSlices ...[]*avax.TransferableOutput) map[ids.ID]uint64 {
produced := make(map[ids.ID]uint64)
for _, outputs := range outputSlices {
for _, out := range outputs {
produced[out.AssetID()] += out.Out.Amount()
}
}
return produced
}
Loading