Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ids.Empty instead of ids.ID{} #3166

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Use ids.Empty instead of ids.ID{} #3166

merged 2 commits into from
Jul 2, 2024

Conversation

dhrubabasu
Copy link
Contributor

Why this should be merged

We should be consistent on which one we use

How this works

Aligns on ids.Empty

How this was tested

CI

@dhrubabasu dhrubabasu added the cleanup Code quality improvement label Jul 2, 2024
@dhrubabasu dhrubabasu added this to the v1.11.9 milestone Jul 2, 2024
@dhrubabasu dhrubabasu self-assigned this Jul 2, 2024
@meaghanfitzgerald
Copy link
Contributor

Did a global search and it says this variable exists in 36 files, this PR changes 25.
i.e. https://github.com/ava-labs/avalanchego/blob/master/vms/components/avax/utxo_fetching.go

image

@dhrubabasu
Copy link
Contributor Author

The remaining 11 hits are []ids.ID{}, not ids.ID{}

@StephenButtolph StephenButtolph added this pull request to the merge queue Jul 2, 2024
Merged via the queue into master with commit deeab24 Jul 2, 2024
20 checks passed
@StephenButtolph StephenButtolph deleted the use-ids-empty branch July 2, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code quality improvement
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants