Enable gossiping of newer IPs when connected to an older IP #3035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
3 tasks
dhrubabasu
approved these changes
May 21, 2024
joshua-kim
approved these changes
May 21, 2024
StephenButtolph
merged commit 20e999d
into
sov-networking-support
17 of 18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Simplifies the restrictions on IP gossip.
Fixes a logical race where a peer may connect and claim an IP that doesn't match their actual IP because they haven't noticed that it changed yet.
How this works
Remove the restriction that in order to gossip an IP the node must be connected with that IP (and that that IP is the most recent IP).
How this was tested