Verify BLS signature provided in Handshake messages #2735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
commented
Feb 13, 2024
Comment on lines
-969
to
-977
| if err := p.VersionCompatibility.Compatible(p.version); err != nil { | ||
| p.Log.Verbo("peer version not compatible", | ||
| zap.Stringer("nodeID", p.id), | ||
| zap.Stringer("peerVersion", p.version), | ||
| zap.Error(err), | ||
| ) | ||
| p.StartClose() | ||
| return | ||
| } |
There was a problem hiding this comment.
Now done in the below p.shouldDisconnect() check
StephenButtolph
requested review from
danlaine and
joshua-kim
as code owners
aaronbuchwald
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
LGTM - agree with @patrick-ogrady 's comment https://github.com/ava-labs/avalanchego/pull/2735/files#r1488716828 on verifying the signature when a validator is added as opposed to periodically when sending ping messages.
| } | ||
|
|
||
| // If Durango hasn't activated on mainnet yet, we don't require BLS | ||
| // signatures to be provided. However, if they are provided, verify that |
patrick-ogrady
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This enforces that nodes are signing their IPs with their BLS keys after the activation of Durango on mainnet. This enforces the mainnet upgrade time rather than the currently running network to provide Fuji operators a time period to update their nodes since the Fuji Durango upgrade has already happened.
If a node provides a BLS signature. It will be verified regardless of the Durango upgrade time.
How this works
How this was tested