Exit chain creation routine before shutting down chain router #2140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darioush
approved these changes
Oct 5, 2023
| @@ -1393,11 +1396,14 @@ func (m *manager) StartChainCreator(platformParams ChainParameters) error { | |||
| m.createChain(platformParams) | |||
|
|
|||
| m.Log.Info("starting chain creator") | |||
| m.chainCreatorExited.Add(1) | |||
There was a problem hiding this comment.
Normally I'd use an exit channel for this given the wg will only ever have value 1?
There was a problem hiding this comment.
looking around in avalanchego - I think it's much more common for us to use a wg than a channel for this. Even with a single goroutine
patrick-ogrady
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Shutting down the chain manager can currently happen concurrently with chain creation: https://github.com/ava-labs/avalanchego/blob/master/chains/manager.go#L1421-L1433. This results in a weird state where a new chain may be added after the chain router is shutdown. Additionally, the rest of the node shutdown process may continue assuming that all chains had finished gracefully shutting down. This can cause unexpected PANICs, FATALs, and ERRORs during shutdown.
How this works
Ensure the chain creation goroutine has exited before shutting down the chain router.
How this was tested