Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Heap Queue #2135

Merged
merged 14 commits into from
Oct 5, 2023
Merged

Add Heap Queue #2135

merged 14 commits into from
Oct 5, 2023

Conversation

joshua-kim
Copy link
Contributor

Why this should be merged

Implements a generic heap

How this works

Implements a generic heap

How this was tested

UT

@joshua-kim joshua-kim marked this pull request as ready for review October 4, 2023 22:08
utils/heap/queue.go Outdated Show resolved Hide resolved
utils/heap/queue.go Outdated Show resolved Hide resolved
utils/heap/queue.go Outdated Show resolved Hide resolved
vms/platformvm/state/staker_diff_iterator.go Outdated Show resolved Hide resolved
vms/platformvm/state/merged_iterator.go Outdated Show resolved Hide resolved
Co-authored-by: Stephen Buttolph <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
@StephenButtolph StephenButtolph added the cleanup Code quality improvement label Oct 5, 2023
utils/heap/queue.go Outdated Show resolved Hide resolved
Copy link
Contributor

@dhrubabasu dhrubabasu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small q

utils/heap/queue.go Show resolved Hide resolved
Signed-off-by: Joshua Kim <[email protected]>
@StephenButtolph StephenButtolph added this to the v1.10.12 milestone Oct 5, 2023
@StephenButtolph StephenButtolph added this pull request to the merge queue Oct 5, 2023
Merged via the queue into dev with commit c520eb6 Oct 5, 2023
16 checks passed
@StephenButtolph StephenButtolph deleted the heap-queue branch October 5, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code quality improvement
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants