Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go.mod and add update check #2133

Merged
merged 4 commits into from
Oct 4, 2023
Merged

Update go.mod and add update check #2133

merged 4 commits into from
Oct 4, 2023

Conversation

StephenButtolph
Copy link
Contributor

@StephenButtolph StephenButtolph commented Oct 4, 2023 •
edited
Loading

Why this should be merged

The current go.mod is stale. We should add a go.mod tidy to our CI.

How this works

  • Runs go mod tidy
  • Adds CI to enforce that the go.mod + go.sum are up-to-date.

How this was tested

CI

@StephenButtolph StephenButtolph changed the title Update go.mod Update go.mod and add update check Oct 4, 2023
@StephenButtolph StephenButtolph added this to the v1.10.12 milestone Oct 4, 2023
@StephenButtolph StephenButtolph added testing This primarily focuses on testing ci This focuses on changes to the CI process labels Oct 4, 2023
@StephenButtolph StephenButtolph marked this pull request as ready for review October 4, 2023 14:59
@StephenButtolph StephenButtolph self-assigned this Oct 4, 2023
@StephenButtolph StephenButtolph added this pull request to the merge queue Oct 4, 2023
Merged via the queue into dev with commit da5e9e6 Oct 4, 2023
16 checks passed
@StephenButtolph StephenButtolph deleted the update-go-mod branch October 4, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshua-kim joshua-kim joshua-kim approved these changes

@abi87 abi87 abi87 approved these changes

@patrick-ogrady patrick-ogrady patrick-ogrady approved these changes

@marun marun marun approved these changes

Assignees

@StephenButtolph StephenButtolph

Labels
ci This focuses on changes to the CI process testing This primarily focuses on testing
Projects
No open projects
Ski Patrol
Archived in project
Milestone
v1.10.12
Development

Successfully merging this pull request may close these issues.
5 participants
@StephenButtolph @marun @patrick-ogrady @abi87 @joshua-kim