RPCChainVM fail-fast health RPCs #2123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hexfusion
changed the title
Signed-off-by: Sam Batschelet <[email protected]>
hexfusion
requested review from
StephenButtolph,
gyuho and
danlaine
as code owners
Signed-off-by: Sam Batschelet <[email protected]>
Signed-off-by: Sam Batschelet <[email protected]>
hexfusion
changed the title
StephenButtolph
approved these changes
Oct 4, 2023
aaronbuchwald
approved these changes
Oct 4, 2023
darioush
reviewed
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Currently the default client config defines all RPCs to
WaitForReadythis means the client call will block forever in the case that the server is terminated.HealthChecks should fail fast to report a failing health check for a VM that has been terminated.
How this works
Fine tune
WaitForReadyas RPC CallOption.ref. https://github.com/grpc/grpc/blob/master/doc/wait-for-ready.md
How this was tested
Manually and CI
TODO: test with ANR and subnet