Move vote bubbling before poll termination #2100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
added
consensus
StephenButtolph
changed the title
danlaine
reviewed
Sep 26, 2023
danlaine
reviewed
Sep 26, 2023
Co-authored-by: Dan Laine <[email protected]> Signed-off-by: Stephen Buttolph <[email protected]>
dhrubabasu
approved these changes
Sep 28, 2023
joshua-kim
approved these changes
Sep 28, 2023
danlaine
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
The bubble votes optimization means that nodes will be providing multiple preferences in response to consensus queries. However, the early poll termination logic doesn't easily support multiple preferences per response. This PR moves the bubbling of votes to happen prior to registering the result in the poll to ensure only one preference needs to be registered into the poll.
How this works
Moves vote bubbling prior to poll registration. This significantly simples the vote bubbling logic. However, it does make the vote bubbling logic slightly more expensive (because traversals happen per-vote rather than per-poll).
How this was tested
CI