Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add last accepted height to the snowman interface #2091

Merged
merged 1 commit into from
Sep 24, 2023

Conversation

StephenButtolph
Copy link
Contributor

Why this should be merged

The last accepted height needs to be exposed to allow the user to determine if a block should be accepted or processing quickly.

How this works

Exposes an already tracked value.

How this was tested

Added additional unit tests.

@StephenButtolph StephenButtolph added consensus This involves consensus bubble votes labels Sep 24, 2023
@StephenButtolph StephenButtolph added this to the v1.10.12 milestone Sep 24, 2023
@StephenButtolph StephenButtolph self-assigned this Sep 24, 2023
Copy link
Contributor

@dhrubabasu dhrubabasu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one qq

snow/consensus/snowman/consensus_test.go Show resolved Hide resolved
@StephenButtolph StephenButtolph added this pull request to the merge queue Sep 24, 2023
Merged via the queue into dev with commit de4910c Sep 24, 2023
16 checks passed
@StephenButtolph StephenButtolph deleted the expose-last-accepted-height branch September 24, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bubble votes consensus This involves consensus
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants