Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add usestdlibvars linter #2080

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Add usestdlibvars linter #2080

merged 1 commit into from
Sep 22, 2023

Conversation

dhrubabasu
Copy link
Contributor

@dhrubabasu dhrubabasu commented Sep 22, 2023 •
edited
Loading 

utils/dynamicip/ifconfig_resolver.go:23:46: "GET" can be replaced by http.MethodGet (usestdlibvars)
        req, err := http.NewRequestWithContext(ctx, "GET", r.url, nil)

@dhrubabasu dhrubabasu added ci This focuses on changes to the CI process cleanup Code quality improvement labels Sep 22, 2023
@dhrubabasu dhrubabasu added this to the v1.10.11 milestone Sep 22, 2023
@dhrubabasu dhrubabasu self-assigned this Sep 22, 2023
@StephenButtolph StephenButtolph added this pull request to the merge queue Sep 22, 2023
Merged via the queue into dev with commit 9c08bc6 Sep 22, 2023
@StephenButtolph StephenButtolph deleted the usestdlibvars branch September 22, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danlaine danlaine danlaine approved these changes

@abi87 abi87 abi87 approved these changes

@StephenButtolph StephenButtolph StephenButtolph approved these changes

@JacobEverly JacobEverly JacobEverly approved these changes

@gyuho gyuho Awaiting requested review from gyuho

@marun marun Awaiting requested review from marun

Assignees

@dhrubabasu dhrubabasu

Labels
ci This focuses on changes to the CI process cleanup Code quality improvement
Projects
No open projects
Ski Patrol
Archived in project
Milestone
v1.10.11
Development

Successfully merging this pull request may close these issues.
5 participants
@dhrubabasu @danlaine @abi87 @StephenButtolph @JacobEverly