Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional validator set metrics #2051

Merged
merged 7 commits into from
Sep 27, 2023
Merged

Conversation

aaronbuchwald
Copy link
Collaborator

@aaronbuchwald aaronbuchwald commented Sep 20, 2023

Why this should be merged

This PR adds a total weight metric to the peer tracker.

How this works

The peer tracker already tracks the total weight in order to calculate the percent connected, so this change adds an additional function to the interface to expose TotalWeight and adds a metric called total_weight into tracked peers.

How this was tested

CI + running locally to get the updated metric:

avalanche_P_total_weight 4e+16
# TYPE avalanche_P_num_validators gauge
avalanche_P_num_validators 20

@aaronbuchwald aaronbuchwald changed the base branch from master to dev September 20, 2023 23:19
@aaronbuchwald aaronbuchwald self-assigned this Sep 20, 2023
@aaronbuchwald aaronbuchwald marked this pull request as ready for review September 20, 2023 23:27
Copy link
Contributor

@StephenButtolph StephenButtolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can get rid of the TotalValidators function - it doesn't seem needed.

@StephenButtolph StephenButtolph added this to the v1.10.12 milestone Sep 26, 2023
@StephenButtolph StephenButtolph added the monitoring This primarily focuses on logs, metrics, and/or tracing label Sep 26, 2023
@StephenButtolph StephenButtolph changed the title Add total weight metric Add additional validator set metrics Sep 26, 2023
@StephenButtolph StephenButtolph added this pull request to the merge queue Sep 27, 2023
Merged via the queue into dev with commit b111ce9 Sep 27, 2023
@StephenButtolph StephenButtolph deleted the add-total-weight-metric branch September 27, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
monitoring This primarily focuses on logs, metrics, and/or tracing
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants