Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e
: Add basic warp test with xsvm #2043e2e
: Add basic warp test with xsvm #2043Changes from all commits
290db26
a1fe898
b769d54
19ba8f1
826efd2
e7b4884
4c949a9
9f1f69d
d15f33a
ab70045
80ea641
16bb522
8e9299e
33eef68
ca8d1a0
b3ea901
2efad6a
119740d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was the main fix for the e2e test. The reason that we need to issue the transfer tx on the destination chain is to update the pChainHeight on the destination subnet to enable verifying the warp message. However, without the flag set, the P-chain height lags by
2
minutes and at least16
blocks. During the test, the P-chain has height 9. So, even if we added a 2 minute sleep, it wouldn't advance past height=0 (which is before the subnet validators are added).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the explanation and fix, much apprecaited!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a test-only flag, or would there ever be reason to use it in production?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's valid to use in a production network.. But not ideal