Merkle db fix range proof commit bug #2019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dboehm-avalabs
requested review from
danlaine,
darioush,
abi87,
gyuho,
marun,
hexfusion,
StephenButtolph and
joshua-kim
as code owners
darioush
reviewed
Sep 14, 2023
Co-authored-by: Darioush Jalali <[email protected]> Signed-off-by: David Boehm <[email protected]>
Co-authored-by: Darioush Jalali <[email protected]> Signed-off-by: David Boehm <[email protected]>
…/ava-labs/avalanchego into MerkleDBFixRangeProofCommitError
darioush
approved these changes
Sep 14, 2023
danlaine
suggested changes
Sep 14, 2023
…/ava-labs/avalanchego into MerkleDBFixRangeProofCommitError
danlaine
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Range Proofs were only being committed in the sync engine if they had key/values present. This normally isn't an issue, but if a range proof gets returned when a change proof was requested (which occurs when it is for a root that has left the history) and the only changes in that range were deletions, then we would skip committing the range proof, which means that any additional keys present in that range would not be deleted.
Fix involves always checking if the range proof needs committing even when it is empty and including the end of the range in question so that all of the correct keys can be deleted.