Refactor subnet validator primary network requirements #2014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhrubabasu
requested review from
danlaine and
StephenButtolph
as code owners
dhrubabasu
commented
Sep 13, 2023
| @@ -524,24 +532,8 @@ func verifyAddPermissionlessValidatorTx( | |||
|
|
|||
| var txFee uint64 | |||
| if tx.Subnet != constants.PrimaryNetworkID { | |||
| primaryNetworkValidator, err := GetValidator(chainState, constants.PrimaryNetworkID, tx.Validator.NodeID) | |||
| if err != nil { | |||
There was a problem hiding this comment.
The functionality change in this PR is adding the following code here:
if err == database.ErrNotFound {
return fmt.Errorf(
"%s %w of the primary network",
validator.NodeID,
ErrNotValidator,
)
}
There was a problem hiding this comment.
to clarify, this should not change validity because the functional change is to provide a more specific error message and both errors are treated the same
dhrubabasu
commented
Sep 13, 2023
Signed-off-by: Dhruba Basu <[email protected]>
dhrubabasu
added
vm
StephenButtolph
approved these changes
Sep 15, 2023
aaronbuchwald
approved these changes
Sep 15, 2023
StephenButtolph
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
De-dupes some logic
How this works
helper function :)
How this was tested
CI