sync -- log tweaks
#2008
Merged
sync -- log tweaks
#2008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlaine
commented
Sep 12, 2023
| @@ -145,6 +145,8 @@ func (m *Manager) Start(ctx context.Context) error { | |||
| return ErrAlreadyStarted | |||
| } | |||
|
|
|||
| m.config.Log.Info("starting sync", zap.Stringer("target root", m.config.TargetRoot)) | |||
There was a problem hiding this comment.
will help for debugging/showing stuff to user
danlaine
commented
Sep 12, 2023
| @@ -539,14 +541,13 @@ func (m *Manager) Wait(ctx context.Context) error { | |||
|
|
|||
| root, err := m.config.DB.GetMerkleRoot(ctx) | |||
| if err != nil { | |||
| m.config.Log.Info("completed with error", zap.Error(err)) | |||
There was a problem hiding this comment.
I feel like the caller should worry about logging this
danlaine
commented
Sep 12, 2023
| @@ -600,7 +604,7 @@ func (m *Manager) setError(err error) { | |||
| m.errLock.Lock() | |||
| defer m.errLock.Unlock() | |||
|
|
|||
| m.config.Log.Error("syncing failed", zap.Error(err)) | |||
| m.config.Log.Error("sync errored", zap.Error(err)) | |||
There was a problem hiding this comment.
syncing --> sync for parallelism
danlaine
commented
Sep 12, 2023
| @@ -662,7 +666,7 @@ func (m *Manager) completeWorkItem(ctx context.Context, work *workItem, largestH | |||
| } | |||
|
|
|||
| // completed the range [work.start, lastKey], log and record in the completed work heap | |||
| m.config.Log.Info("completed range", | |||
| m.config.Log.Debug("completed range", | |||
There was a problem hiding this comment.
I feel like the user doesn't need to see all these, so made it debug
danlaine
commented
Sep 12, 2023
| @@ -568,6 +571,7 @@ func (m *Manager) UpdateSyncTarget(syncTargetRoot ids.ID) error { | |||
| return nil | |||
| } | |||
|
|
|||
| m.config.Log.Debug("updated sync target", zap.Stringer("target", syncTargetRoot)) | |||
darioush
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
See comments
How this works
n/a
How this was tested
n/a