Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

longer timeout on windows UT #2001

Merged
merged 8 commits into from
Sep 12, 2023
Merged

Conversation

danlaine
Copy link

@danlaine danlaine commented Sep 11, 2023

Why this should be merged

Flaky tests bad.

How this works

Extend timeout for windows UT to 240s. Others still use 120s.

How this was tested

Look at action run and see that TIMEOUT env var is set.

@danlaine danlaine added testing This primarily focuses on testing ci This focuses on changes to the CI process labels Sep 11, 2023
@danlaine danlaine self-assigned this Sep 11, 2023
@danlaine danlaine marked this pull request as ready for review September 11, 2023 20:36
@danlaine danlaine marked this pull request as draft September 12, 2023 13:34
@danlaine danlaine marked this pull request as ready for review September 12, 2023 14:17
@StephenButtolph StephenButtolph merged commit dfc5225 into dev Sep 12, 2023
16 checks passed
@StephenButtolph StephenButtolph deleted the extend-unit-test-timeout-windows branch September 12, 2023 15:33
@StephenButtolph StephenButtolph added this to the v1.10.10 milestone Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci This focuses on changes to the CI process testing This primarily focuses on testing
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants