Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add p2p SDK Router metrics #2000

Merged
merged 12 commits into from
Sep 11, 2023
Merged

Add p2p SDK Router metrics #2000

merged 12 commits into from
Sep 11, 2023

Conversation

joshua-kim
Copy link
Contributor

Why this should be merged

Adds handler-level time metrics to the sdk

How this works

Uses a map of averagers

How this was tested

UT's pass

@StephenButtolph StephenButtolph added this to the v1.10.10 milestone Sep 11, 2023
@StephenButtolph StephenButtolph added monitoring This primarily focuses on logs, metrics, and/or tracing networking This involves networking sdk This involves SDK tooling or frameworks labels Sep 11, 2023
@StephenButtolph StephenButtolph changed the title Router metrics Add p2p SDK Router metrics Sep 11, 2023
Copy link
Contributor

@patrick-ogrady patrick-ogrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@StephenButtolph StephenButtolph merged commit e58b3e0 into dev Sep 11, 2023
@StephenButtolph StephenButtolph deleted the router-metrics branch September 11, 2023 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
monitoring This primarily focuses on logs, metrics, and/or tracing networking This involves networking sdk This involves SDK tooling or frameworks
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants