merkledb -- limit number of goroutines calculating node IDs
#1960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlaine
commented
Sep 5, 2023
| wg sync.WaitGroup | ||
| updatedChildren = make(chan *node, len(n.children)) | ||
| ) | ||
|
|
||
| for childIndex, child := range n.children { | ||
| childIndex, child := childIndex, child |
There was a problem hiding this comment.
Don't think this was actually necessary
darioush
approved these changes
Sep 5, 2023
| if err = eg.Wait(); err != nil { | ||
| return | ||
| } | ||
| _ = t.db.calculateNodeIDsSema.Acquire(context.Background(), 1) |
There was a problem hiding this comment.
is this to have the # of threads match the semaphore weight?
There was a problem hiding this comment.
Not sure I understand the question. In order for a new goroutine to run calculateNodeIDsHelper, it must acquire 1 from the semaphore and release that 1 when it exits the goroutine.
added 2 commits
September 5, 2023 13:22
dboehm-avalabs
approved these changes
Sep 5, 2023
added 4 commits
September 5, 2023 13:54
…a-labs/avalanchego into merkledb-limit-calculation-goroutines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Resolves TODO. Alternate to #1957.
How this works
Uses a semaphore to control the number of goroutines calculating node IDs (namely the number of goroutines executing
calculateNodeIDsHelper) across all views.In
calculateNodeIDs, we will block until we acquire from the semaphore before callingcalculateNodeIDsHelper.In
calculateNodeIDsHelper, we callcalculateNodeIDsHelperin a goroutine iff the semaphore has unused resources. Otherwise, we callcalculateNodeIDsHelperrecursively.How this was tested
Existing UT