-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MerkleDB Improve Node Size Calculation #1950
Conversation
I think it might suffice to just change return len(p) + 2*len(n.marshal()) It won't be exactly right but it'll be pretty close and the diff is 2 characters, which is nice. |
I'm cool with it if no one cares about it being 100% accurate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just nits
The node that is being stored in the cache contains more than just its bytes, so make the size calculation more accurate by tracking its total size.