e2e: Add bootstrap checks to migrated kurtosis tests #1935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlaine
approved these changes
Aug 29, 2023
marun
force-pushed
the
e2e-add-bootstrap-check
branch
from
95edd86
to
a453158
Compare
|
Rebased on #1941 and converted to draft to ensure that e2e failures are minimized. |
marun
force-pushed
the
e2e-add-bootstrap-check
branch
from
a453158
to
e5b9a3c
Compare
marun
force-pushed
the
e2e-add-bootstrap-check
branch
from
862834f
to
2bbb837
Compare
hexfusion
approved these changes
Sep 8, 2023
danlaine
approved these changes
Sep 12, 2023
Signed-off-by: Stephen Buttolph <[email protected]>
StephenButtolph
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
One of the requirements of #1547 was to ensure that the new tests checked that the post-test network state was capable of bootstrapping a new node. With the merge of #1573 the testnet fixture supports adding node addition and this PR ensures that the 2 tests previously migrated from kurtosis are updated to perform a post-test bootstrap check. In-flight migration PRs will be updated to include the new check.
How this works
Add a new helper method to support post-test addition of a new node and checking that it becomes healthy (i.e. bootstraps successfully).
How this was tested
CI and locally checking that E2E_SKIP_BOOTSTRAP_CHECKS=1 was capable of disabling the bootstrap check during development.
TODO