Implement SDK handler to drop messages from non-validators #1917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hexfusion
reviewed
Aug 25, 2023
| // ValidatorHandler drops messages from non-validators | ||
| type ValidatorHandler struct { | ||
| Handler | ||
| ValidatorSet ValidatorSet |
There was a problem hiding this comment.
I know we don't do this very well in the rest of the repo... but should we make this a minimal interface? Doesn't seem like we need any of the sampling functionality here.
StephenButtolph
approved these changes
Aug 28, 2023
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: Joshua Kim <[email protected]>
abi87
approved these changes
Aug 28, 2023
dhrubabasu
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Implements a handler that drops messages from non-validators
How this works
Adds a
ValidatorSetinterface we lookup incoming nodeIDs from to see if we should handle the request or not.How this was tested
Added a unit test