merkledb -- use Maybe for start bounds
#1872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlaine
requested review from
darioush,
dboehm-avalabs,
gyuho,
hexfusion and
StephenButtolph
as code owners
x/sync/workheap.go
Outdated
| heap.Fix(&wh.innerHeap, afterItem.heapIndex) | ||
| mergedAfter = afterItem | ||
| if item.localRootID == afterItem.workItem.localRootID { | ||
| if maybe.Equal(item.end, afterItem.workItem.start, bytes.Equal) { |
There was a problem hiding this comment.
reason to split the if?
There was a problem hiding this comment.
Re-added && and removed second if
dboehm-avalabs
approved these changes
Aug 18, 2023
| @@ -42,6 +47,13 @@ func (m Maybe[T]) Value() T { | |||
| return m.value | |||
| } | |||
|
|
|||
| func (m Maybe[T]) String() string { | |||
There was a problem hiding this comment.
was this used anywhere?
There was a problem hiding this comment.
Yes in manager.go:
zap.Stringer("start", work.start),
zap.Stringer("end", largestHandledKey),
dboehm-avalabs
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
We already use
Maybefor end bounds so we should use them for start bounds for xonsistency.How this works
Change
[]bytetomaybe.Maybe[[]byte]for start bounds.How this was tested
Update existing UT