Check P-chain ShouldPrune during Initialize #1836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
commented
Aug 10, 2023
Comment on lines
-2346
to
-2359
| shouldPrune, err := s.shouldPrune() | ||
| if err != nil { | ||
| lock.Unlock() | ||
| return fmt.Errorf( | ||
| "failed to check if the database should be pruned: %w", | ||
| err, | ||
| ) | ||
| } | ||
| if !shouldPrune { | ||
| lock.Unlock() | ||
|
|
||
| log.Info("state already pruned and indexed") | ||
| return nil | ||
| } |
There was a problem hiding this comment.
This check was moved into vm.Initialize
| } | ||
| if !shouldPrune { | ||
| chainCtx.Log.Info("state already pruned and indexed") | ||
| vm.pruned.Set(true) |
There was a problem hiding this comment.
By setting pruned here - we guaranteed that we will return nil from VerifyHeightIndex if the P-chain has already been pruned (even if it is called immediately after Initialize).
patrick-ogrady
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Ensures the proposervm doesn't repair its own index multiple times.
How this works
Verifies the platformvm height index on initialize.
How this was tested
CI