Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e: Migrate staking rewards test from kurtosis #1767

Merged
merged 9 commits into from
Sep 21, 2023
Merged

e2e: Migrate staking rewards test from kurtosis #1767

merged 9 commits into from
Sep 21, 2023

Conversation

marun
Copy link
Contributor

@marun marun commented Jul 27, 2023 •
edited
Loading

Why this should be merged

Fulfills one of the requirements for #1547 (migration of Kurtosis tests)

How this works

How this was tested

CI

TODO

@marun marun mentioned this pull request Jul 27, 2023
Closed
16 tasks
@marun marun force-pushed the e2e-staking-rewards branch 10 times, most recently from e7373ba to 0d12347 Compare August 2, 2023 00:48
@marun marun mentioned this pull request Aug 2, 2023
Merged
1 task
@marun marun added the testing This primarily focuses on testing label Aug 2, 2023
@marun marun force-pushed the e2e-staking-rewards branch 5 times, most recently from 7de6c18 to 5786184 Compare August 8, 2023 23:47
@marun marun force-pushed the e2e-staking-rewards branch 4 times, most recently from 502ad63 to 7e81149 Compare August 22, 2023 00:11
@marun marun linked an issue Aug 23, 2023 that may be closed by this pull request
Migrate Kurtosis Tests #1547
Closed
16 tasks
@marun marun self-assigned this Aug 23, 2023
@marun marun marked this pull request as ready for review August 27, 2023 18:54
@marun marun mentioned this pull request Sep 1, 2023
Merged
@marun marun force-pushed the e2e-staking-rewards branch 3 times, most recently from cc10153 to b73bdf0 Compare September 7, 2023 01:09
@marun marun marked this pull request as ready for review September 7, 2023 01:10
hexfusion
hexfusion approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@hexfusion hexfusion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

@marun
Copy link
Contributor Author

marun commented Sep 21, 2023

Rebased

abi87
abi87 suggested changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@abi87 abi87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit about the way we calculate delegator reward split here. Other than that LGTM

@abi87 abi87 mentioned this pull request Sep 21, 2023
Merged
1 task
@StephenButtolph StephenButtolph added this pull request to the merge queue Sep 21, 2023
Merged via the queue into dev with commit e8c32b3 Sep 21, 2023
16 checks passed
@StephenButtolph StephenButtolph deleted the e2e-staking-rewards branch September 21, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephenButtolph StephenButtolph StephenButtolph approved these changes

@abi87 abi87 abi87 approved these changes

@danlaine danlaine danlaine approved these changes

@hexfusion hexfusion hexfusion approved these changes

@gyuho gyuho Awaiting requested review from gyuho

@aaronbuchwald aaronbuchwald Awaiting requested review from aaronbuchwald

Assignees

@marun marun

Labels
testing This primarily focuses on testing
Projects
No open projects
Ski Patrol
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate Kurtosis Tests
5 participants
@marun @hexfusion @danlaine @abi87 @StephenButtolph