x/sync: add locks for peerTracker #1756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we want to remove any locking from |
patrick-ogrady
changed the title
patrick-ogrady
approved these changes
Jul 24, 2023
x/sync/network_client.go
Outdated
| return ids.EmptyNodeID, nil, fmt.Errorf( | ||
| "no peers found matching version %s out of %d peers", | ||
| minVersion, c.peers.Size(), | ||
| ) | ||
| } | ||
|
|
||
| // Note [c.request] releases [c.lock]. | ||
| c.lock.Lock() |
There was a problem hiding this comment.
I think we can move grabbing this lock into request() now right?
StephenButtolph
approved these changes
Jul 25, 2023
This was referenced Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #1750
Replaces: #1751
Why this should be merged
Fixes issues with concurrent map accesses during sync.
It seems this data structure could be used concurrently (comparatively the locking overhead seems small).
How this works
Adds lock for the peer tracker.
How this was tested
UT, hyper SDK CI ava-labs/hypersdk#272