Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vms/platformvm: configure state cache sizes #1522 #1677

Merged
merged 10 commits into from
Jul 22, 2023

Conversation

najeal
Copy link
Contributor

@najeal najeal commented Jun 30, 2023

Why this should be merged

It resolves and close #1522

How this works

It defines an execution config used to configure platformvm state cache size.
A default config is used and overridden by configBytes arg in the Initialize() function of the VM.

How this was tested

Unit test of the default config and the override of the values.

Copy link
Contributor

@abi87 abi87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nits and a couple of major requests (repackage execConfig + move trackChecksum in). Overall very helpful cleanup. Thanks @najeal!

Copy link
Contributor

@abi87 abi87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@najeal a couple of nits, then it's good to me. I'll approve as soon as you fix them

@najeal
Copy link
Contributor Author

najeal commented Jul 7, 2023

@abi87 I have seen all json configs in the project are camelCase. So the created config has camelCase keys except the ChecksumsEnabled because I would potentially break something...
It's not consistent but I have no choice.

By the way if you have others issues for new comers don't hesitate to mention me.

@abi87
Copy link
Contributor

abi87 commented Jul 7, 2023

@abi87 I have seen all json configs in the project are camelCase. So the created config has camelCase keys except the ChecksumsEnabled because I would potentially break something... It's not consistent but I have no choice.

By the way if you have others issues for new comers don't hesitate to mention me.

I am sure you alread looked at the good first issues. Will check if there other outstanding ones and duly tag them. Thanks for your contribution @najeal

@najeal
Copy link
Contributor Author

najeal commented Jul 7, 2023

@abi87 yes I did :)

@abi87 abi87 added the vm This involves virtual machines label Jul 7, 2023
Copy link
Contributor

@StephenButtolph StephenButtolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 last super small nits then LGTM. Sorry for the long turn-around on these reviews

@StephenButtolph StephenButtolph added this to the v1.10.6 milestone Jul 20, 2023
@StephenButtolph StephenButtolph merged commit 69c98d5 into ava-labs:dev Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vm This involves virtual machines
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants