-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vms/platformvm: configure state cache sizes #1522 #1677
vms/platformvm: configure state cache sizes #1522 #1677
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some nits and a couple of major requests (repackage execConfig + move trackChecksum in). Overall very helpful cleanup. Thanks @najeal!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@najeal a couple of nits, then it's good to me. I'll approve as soon as you fix them
@abi87 I have seen all json configs in the project are camelCase. So the created config has camelCase keys except the ChecksumsEnabled because I would potentially break something... By the way if you have others issues for new comers don't hesitate to mention me. |
I am sure you alread looked at the good first issues. Will check if there other outstanding ones and duly tag them. Thanks for your contribution @najeal |
@abi87 yes I did :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just 2 last super small nits then LGTM. Sorry for the long turn-around on these reviews
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: nathan haim <[email protected]>
Signed-off-by: Stephen Buttolph <[email protected]>
Why this should be merged
It resolves and close #1522
How this works
It defines an execution config used to configure platformvm state cache size.
A default config is used and overridden by
configBytes
arg in theInitialize()
function of the VM.How this was tested
Unit test of the default config and the override of the values.