Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Proof size limit to sync client #1269

Merged
merged 55 commits into from
Apr 17, 2023
Merged

Add Proof size limit to sync client #1269

merged 55 commits into from
Apr 17, 2023

Conversation

dboehm-avalabs
Copy link
Contributor

Since values can be arbitrarily long, proofs could end up larger than the allowed network message size. Add a mechanism to limit proofs to a reasonable size.

x/sync/network_server.go Outdated Show resolved Hide resolved
x/sync/network_server_test.go Outdated Show resolved Hide resolved
x/sync/network_server_test.go Outdated Show resolved Hide resolved
x/sync/network_server_test.go Outdated Show resolved Hide resolved
x/sync/network_server_test.go Outdated Show resolved Hide resolved
x/sync/network_server_test.go Outdated Show resolved Hide resolved
StephenButtolph pushed a commit to krakxn/avalanchego that referenced this pull request Mar 31, 2023
@danlaine danlaine changed the base branch from master to dev April 3, 2023 20:19
@danlaine danlaine self-requested a review as a code owner April 3, 2023 20:19
x/sync/syncmanager.go Outdated Show resolved Hide resolved
x/sync/syncmanager.go Outdated Show resolved Hide resolved
x/sync/network_server.go Outdated Show resolved Hide resolved
x/sync/network_server.go Outdated Show resolved Hide resolved
x/sync/network_server.go Outdated Show resolved Hide resolved
x/sync/network_server.go Outdated Show resolved Hide resolved
x/sync/network_server.go Outdated Show resolved Hide resolved
x/sync/network_server.go Outdated Show resolved Hide resolved
x/sync/network_server_test.go Show resolved Hide resolved
x/merkledb/history.go Outdated Show resolved Hide resolved
x/sync/network_server.go Outdated Show resolved Hide resolved
x/sync/README.md Show resolved Hide resolved
x/sync/network_server_test.go Outdated Show resolved Hide resolved
@danlaine danlaine merged commit 117dc3a into dev Apr 17, 2023
@danlaine danlaine deleted the ProofSizes branch April 17, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants