Skip to content

Commit

Permalink
Dump stacktrace upon SIGABRT (#3366)
Browse files Browse the repository at this point in the history
Signed-off-by: Yacov Manevich <[email protected]>
  • Loading branch information
yacovm authored and michaelkaplan13 committed Sep 11, 2024
1 parent 0a8d9c6 commit d762a75
Showing 1 changed file with 23 additions and 8 deletions.
31 changes: 23 additions & 8 deletions app/app.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import (
"golang.org/x/sync/errgroup"

"github.com/ava-labs/avalanchego/node"
"github.com/ava-labs/avalanchego/utils"
"github.com/ava-labs/avalanchego/utils/logging"
"github.com/ava-labs/avalanchego/utils/perms"
"github.com/ava-labs/avalanchego/utils/ulimit"
Expand Down Expand Up @@ -90,26 +91,40 @@ func Run(app App) int {
return 1
}

// register signals to kill the application
signals := make(chan os.Signal, 1)
signal.Notify(signals, syscall.SIGINT)
signal.Notify(signals, syscall.SIGTERM)
// register terminationSignals to kill the application
terminationSignals := make(chan os.Signal, 1)
signal.Notify(terminationSignals, syscall.SIGINT, syscall.SIGTERM)

stackTraceSignal := make(chan os.Signal, 1)
signal.Notify(stackTraceSignal, syscall.SIGABRT)

// start up a new go routine to handle attempts to kill the application
var eg errgroup.Group
eg.Go(func() error {
for range signals {
for range terminationSignals {
return app.Stop()
}
return nil
})

// start a goroutine to listen on SIGABRT signals,
// to print the stack trace to standard error.
go func() {
for range stackTraceSignal {
fmt.Fprint(os.Stderr, utils.GetStacktrace(true))
}
}()

// wait for the app to exit and get the exit code response
exitCode, err := app.ExitCode()

// shut down the signal go routine
signal.Stop(signals)
close(signals)
// shut down the termination signal go routine
signal.Stop(terminationSignals)
close(terminationSignals)

// shut down the stack trace go routine
signal.Stop(stackTraceSignal)
close(stackTraceSignal)

// if there was an error closing or running the application, report that error
if eg.Wait() != nil || err != nil {
Expand Down

0 comments on commit d762a75

Please sign in to comment.