Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix import issues #33

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Attempt to fix import issues #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9feee1a
Build commonjs variants of the code for importing
ava-cassiopeia Jan 8, 2025
3fcc171
Use new commonjs as main file
ava-cassiopeia Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions gulpfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,11 @@
const gulp = require("gulp");
const sass = require("gulp-sass")(require("node-sass"));
const webpackStream = require("webpack-stream");
const webpack2 = require("webpack");
const uglify = require("gulp-uglify");
const zip = require("gulp-zip");
const clean = require("gulp-clean");
const ts = require("gulp-typescript");
const args = require("really-simple-args")();

const tsProject = ts.createProject("src/typescript/tsconfig.json");

const OUTPUT_DIR = "dist";

const JS_SRCS = ["src/javascript/*.js", "src/javascript/**/*.js"];
Expand All @@ -30,12 +26,11 @@ function buildCSS() {
.pipe(gulp.dest(`${OUTPUT_DIR}/css/`));
}

function buildJS() {
function buildReleaseJS() {
return gulp.src(TS_SRCS)
.pipe(webpackStream({
mode: "production",
entry: {
// Possible add .min here?
SimpleSwitch: "./src/typescript/index.ts",
},
module: {
Expand All @@ -58,9 +53,20 @@ function buildJS() {
.pipe(gulp.dest(`${OUTPUT_DIR}/js/`));
}

function buildJS() {
return gulp.src(TS_SRCS)
.pipe(ts({
target: "es6",
module: "nodenext",
moduleResolution: "nodenext",
declaration: true, // generate .d.ts files
}))
.pipe(gulp.dest(`${OUTPUT_DIR}/commonjs/`));
}

function watch() {
gulp.watch(CSS_SRCS, buildCSS);
gulp.watch(JS_SRCS, buildJS);
gulp.watch(JS_SRCS, buildJS, buildReleaseJS);
}

/**
Expand Down Expand Up @@ -102,12 +108,12 @@ function cleanBuildArtifacts() {
]).pipe(clean());
}

exports.default = gulp.parallel(buildCSS, buildJS);
exports.default = gulp.parallel(buildCSS, buildJS, buildReleaseJS);
exports.buildCSS = buildCSS;
exports.buildJS = buildJS;
exports.watch = watch;
exports.buildRelease = gulp.series(
gulp.parallel(buildCSS, buildJS, prepareReleaseSass),
gulp.parallel(buildCSS, buildJS, buildReleaseJS, prepareReleaseSass),
prepareRelease,
buildRelease,
);
Expand Down
5 changes: 3 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "a-simple-switch",
"version": "0.9.2",
"description": "Vanilla JS/CSS Switch UI element",
"main": "release/js/SimpleSwitch.min.js",
"main": "release/commonjs/index.js",
"files": [
"release",
"readme.md"
Expand Down
Loading