Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify libprotonup with both path and version #25

Merged
merged 1 commit into from
Jun 9, 2024

Conversation

themadprofessor
Copy link
Contributor

Continuing from #24

Turns out cargo supports both a path and version for specifying dependencies. We can likely do the crate publish in a single cargo publish, and do releases on main rather than release branches.

I've not touched the github workflow as I've not worked with them before and don't want to break it.

@auyer auyer added the ☁️ CI GitHub Actions needs some fixing label Jun 4, 2024
@auyer
Copy link
Owner

auyer commented Jun 4, 2024

Thanks. I will take a look at this soon.

@auyer
Copy link
Owner

auyer commented Jun 9, 2024

I made a few tests, and I think its going to work!
I will merge your PR and make the changes release from the main branch.

@auyer auyer merged commit 465b3e9 into auyer:main Jun 9, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☁️ CI GitHub Actions needs some fixing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants