Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(github-release.yaml): remove target option #29

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Jan 23, 2025

Description

The autoware repository has tags in the main branch, but other branches have tags in the either main or humble branches. In other words, specifying the main branch may result in cases where the github-release workflow does not work. The target option is not mandatory, and if not specified, the branch with tags will be automatically selected, so this PR removes the option.

How was this PR tested?

Notes for reviewers

None.

Effects on system behavior

None.

Signed-off-by: Yutaka Kondo <[email protected]>
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@youtalk youtalk self-assigned this Jan 23, 2025
@youtalk youtalk added the bug Something isn't working label Jan 23, 2025
@youtalk youtalk enabled auto-merge (squash) January 23, 2025 01:11
@youtalk
Copy link
Member Author

youtalk commented Jan 27, 2025

@rej55 @mitsudome-r @xmfcx Please review this. It's one line change.

Copy link

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@youtalk youtalk merged commit 82e16a2 into main Jan 27, 2025
5 checks passed
@youtalk youtalk deleted the fix/github-release-target branch January 27, 2025 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants