Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_launch): set use_sim_time parameter equal to true when … #746

Conversation

pawellech1
Copy link
Contributor

@pawellech1 pawellech1 commented Dec 19, 2023

Description

In order to set global use_sim_time parameter value to True by default when the simulation is run the use_sim_time argument in the planning_simulator launch file was declared. Its value is set to be equal to the scenario_simulation parameter value.

Tests performed

I tested the system with the scenario simulator and global use_sim_time parameter is in fact changed.

Effects on system behavior

The use_sim_time global parameter value is set to True by default when the simulation is run.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…scenario simulation is used

Signed-off-by: Paweł Lech <[email protected]>
@pawellech1 pawellech1 marked this pull request as ready for review February 14, 2024 16:21
@maxime-clem
Copy link
Contributor

This change prevents from using use_sim_time:=true outside of using the scenario_simulation.
Previously I would add the argument to my launch command ros2 launch ... use_sim_time:=true but this is no longer possible and I had to revert the changes of this PR.

@takayuki5168
Copy link
Contributor

@xmfcx I also want to enable use_sim_time when using the simple planning simulator as Maxime-san mentioned above. Can you please fix it?

@xmfcx
Copy link
Contributor

xmfcx commented Mar 1, 2024

@takayuki5168 @maxime-clem alright, I'll revert it right away.

xmfcx pushed a commit that referenced this pull request Mar 1, 2024
xmfcx pushed a commit that referenced this pull request Mar 1, 2024
xmfcx pushed a commit that referenced this pull request Mar 1, 2024
xmfcx added a commit that referenced this pull request Mar 1, 2024
badai-nguyen pushed a commit to badai-nguyen/autoware_launch that referenced this pull request Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants