Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(localization_error_monitor): update default parameter #565

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Sep 13, 2023

Description

Update default parameter, as the logging simulator tutorial outputs warning, which indicates that the threshold are not correctly set.

Tests performed

Confirmed that there is no warning

Effects on system behavior

Not applicable

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kminoda kminoda requested a review from YamatoAndo September 13, 2023 06:02
@kminoda kminoda marked this pull request as ready for review September 13, 2023 06:02
@kminoda kminoda merged commit 7f675e2 into autowarefoundation:main Sep 13, 2023
kminoda pushed a commit to kminoda/autoware_launch that referenced this pull request Sep 13, 2023
danielsanchezaran referenced this pull request in tier4/autoware_launch Sep 21, 2023
soblin pushed a commit to soblin/autoware_launch that referenced this pull request Nov 18, 2023
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request May 21, 2024
* feat: tune condition of between cruise and stop (autowarefoundation#565)

Tune condition of between cruise and stop

* fix(traffic_light): stop if the traffic light signal timed out (autowarefoundation#727) (autowarefoundation#571)

Signed-off-by: Fumiya Watanabe <[email protected]>
Co-authored-by: Fumiya Watanabe <[email protected]>

* feat(component_state_monitor): monitor traffic light recognition outp… (autowarefoundation#572)

feat(component_state_monitor): monitor traffic light recognition output (autowarefoundation#720)

Signed-off-by: Tomohito Ando <[email protected]>

* update ground segmentation

Signed-off-by: yoshiri <[email protected]>

* update comparemap parameter

Signed-off-by: yoshiri <[email protected]>

* update clustering parameters

Signed-off-by: yoshiri <[email protected]>

* fix tracking iou threshold parameters

Signed-off-by: yoshiri <[email protected]>

* feat: set smaller  threshold for euclidean clustering

Signed-off-by: yoshiri <[email protected]>

* chore: fit parameter for v3.0.0

Signed-off-by: yoshiri <[email protected]>

---------

Signed-off-by: Fumiya Watanabe <[email protected]>
Signed-off-by: Tomohito Ando <[email protected]>
Signed-off-by: yoshiri <[email protected]>
Co-authored-by: Shohei Sakai <[email protected]>
Co-authored-by: Tomohito ANDO <[email protected]>
Co-authored-by: Fumiya Watanabe <[email protected]>
Co-authored-by: Shinnosuke Hirakawa <[email protected]>
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request May 21, 2024
…) (autowarefoundation#590)

Tune condition of between cruise and stop

Co-authored-by: Shohei Sakai <[email protected]>
Co-authored-by: Shinnosuke Hirakawa <[email protected]>
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Jun 18, 2024
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Jun 18, 2024
…threshold (autowarefoundation#619)

chore(localization_error_monitor): update default parameter (autowarefoundation#565)

Signed-off-by: kminoda <[email protected]>
Co-authored-by: kminoda <[email protected]>
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Jun 18, 2024
…tion#604)

chore(localization_error_monitor): update default parameter (autowarefoundation#565)

Signed-off-by: kminoda <[email protected]>
Co-authored-by: kminoda <[email protected]>
yuki-takagi-66 referenced this pull request in tier4/autoware_launch Jul 8, 2024
* feat: tune condition of between cruise and stop (#565)

Tune condition of between cruise and stop

* fix(traffic_light): stop if the traffic light signal timed out (#727) (#571)

Signed-off-by: Fumiya Watanabe <[email protected]>
Co-authored-by: Fumiya Watanabe <[email protected]>

* feat(component_state_monitor): monitor traffic light recognition outp… (#572)

feat(component_state_monitor): monitor traffic light recognition output (#720)

Signed-off-by: Tomohito Ando <[email protected]>

* update ground segmentation

Signed-off-by: yoshiri <[email protected]>

* update comparemap parameter

Signed-off-by: yoshiri <[email protected]>

* update clustering parameters

Signed-off-by: yoshiri <[email protected]>

* fix tracking iou threshold parameters

Signed-off-by: yoshiri <[email protected]>

* feat: set smaller  threshold for euclidean clustering

Signed-off-by: yoshiri <[email protected]>

* chore: fit parameter for v3.0.0

Signed-off-by: yoshiri <[email protected]>

---------

Signed-off-by: Fumiya Watanabe <[email protected]>
Signed-off-by: Tomohito Ando <[email protected]>
Signed-off-by: yoshiri <[email protected]>
Co-authored-by: Shohei Sakai <[email protected]>
Co-authored-by: Tomohito ANDO <[email protected]>
Co-authored-by: Fumiya Watanabe <[email protected]>
Co-authored-by: Shinnosuke Hirakawa <[email protected]>
yuki-takagi-66 referenced this pull request in tier4/autoware_launch Jul 8, 2024
Tune condition of between cruise and stop

Co-authored-by: Shohei Sakai <[email protected]>
Co-authored-by: Shinnosuke Hirakawa <[email protected]>
Kazunori-Nakajima pushed a commit to Kazunori-Nakajima/autoware_launch that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants