Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(control_validator): default false for publishing diag and display terminal #545

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

kyoichi-sugahara
Copy link
Contributor

Description

suppress warning message and publish diag for now.
Apparently it has problem with code.
I will revert this PR's change after solve the problem.

Tests performed

Checked no warning is shown in terminal.

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@satoshi-ota satoshi-ota self-requested a review August 31, 2023 02:39
@kyoichi-sugahara kyoichi-sugahara merged commit 250defe into main Aug 31, 2023
@kyoichi-sugahara kyoichi-sugahara deleted the fix/disenge_control_validator_temporary branch August 31, 2023 02:43
kyoichi-sugahara pushed a commit that referenced this pull request Sep 3, 2023
kyoichi-sugahara pushed a commit that referenced this pull request Sep 3, 2023
chore: sync awf/autoware_launch
kminoda pushed a commit to kminoda/autoware_launch that referenced this pull request Sep 13, 2023
… terminal (autowarefoundation#545)

default false for publishing diag and display terminal

Signed-off-by: kyoichi-sugahara <[email protected]>
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request May 21, 2024
* feat(scenario_planning): change common jerk to 0.3 mainly for jerk
filtered smoother

Signed-off-by: Makoto Kurihara <[email protected]>

* feat(autoware_launch): change to JerkFiltered smoother

Signed-off-by: Makoto Kurihara <[email protected]>

* Increase max_jerk: 0.3 -> 0.6

---------

Signed-off-by: Makoto Kurihara <[email protected]>
Co-authored-by: Makoto Kurihara <[email protected]>
Co-authored-by: Takayuki Murooka <[email protected]>
yuki-takagi-66 referenced this pull request in tier4/autoware_launch Jul 8, 2024
* feat(scenario_planning): change common jerk to 0.3 mainly for jerk
filtered smoother

Signed-off-by: Makoto Kurihara <[email protected]>

* feat(autoware_launch): change to JerkFiltered smoother

Signed-off-by: Makoto Kurihara <[email protected]>

* Increase max_jerk: 0.3 -> 0.6

---------

Signed-off-by: Makoto Kurihara <[email protected]>
Co-authored-by: Makoto Kurihara <[email protected]>
Co-authored-by: Takayuki Murooka <[email protected]>
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Sep 3, 2024
…k/map-based-pred-debug-options

chore(map_based_prediction): debug options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants