Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: porting autoware_motion_utils from universe to core #184

Conversation

sasakisasaki
Copy link
Contributor

@sasakisasaki sasakisasaki commented Feb 12, 2025

Description

This PR is for porting a module from autoware.universe/common/autoware_motion_utils to autoware.core/common/autoware_motion_utils

WARNING: This PR MUST BE MERGED BY FOLLOWING STEPS:

  • This PR is merged
  • Create a PR that removes the autoware_motion_utils from autoware.universe/common (PR-A)
  • Merge the both this PR and autoware.universe side PR at the same time

Related links

How was this PR tested?

autoware.universe side

Ongoing => Done as this result

autoware.core side

mkdir src
vcs import src < build_depends.repos
rosdep install -y --from-paths . --ignore-src --rosdistro $ROS_DISTRO
colcon build --base-paths . --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release

Notes for reviewers

Please do not approve until the preparation for merge is not done yet.

Interface changes

None.

Effects on system behavior

The autoware_motion_utils is no longer available from the autoware.universe, but available via autoware.core

Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 59.39470% with 644 lines in your changes missing coverage. Please review.

Project coverage is 46.73%. Comparing base (4cb18f5) to head (49c0058).
Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
...n_utils/test/src/trajectory/test_interpolation.cpp 27.27% 2 Missing and 286 partials ⚠️
...ls/test/src/vehicle/test_vehicle_state_checker.cpp 62.40% 0 Missing and 94 partials ⚠️
...on/autoware_motion_utils/src/resample/resample.cpp 79.81% 36 Missing and 29 partials ⚠️
...autoware_motion_utils/src/marker/marker_helper.cpp 49.15% 30 Missing ⚠️
...st/src/marker/test_virtual_wall_marker_creator.cpp 53.22% 0 Missing and 29 partials ⚠️
...ils/test/src/trajectory/test_path_with_lane_id.cpp 66.25% 1 Missing and 26 partials ⚠️
...on/autoware_motion_utils/src/distance/distance.cpp 53.48% 16 Missing and 4 partials ⚠️
...tion_utils/test/src/trajectory/test_path_shift.cpp 33.33% 0 Missing and 20 partials ⚠️
...est/src/trajectory/benchmark_calcLateralOffset.cpp 0.00% 19 Missing ⚠️
...utoware_motion_utils/src/trajectory/trajectory.cpp 0.00% 11 Missing ⚠️
... and 8 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #184       +/-   ##
===========================================
- Coverage   78.75%   46.73%   -32.03%     
===========================================
  Files          11       51       +40     
  Lines         193     7894     +7701     
  Branches       73     5677     +5604     
===========================================
+ Hits          152     3689     +3537     
- Misses         11      780      +769     
- Partials       30     3425     +3395     
Flag Coverage Δ *Carryforward flag
differential 45.92% <59.39%> (?)
total 78.75% <ø> (ø) Carriedforward from 4cb18f5

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sasakisasaki added a commit to sasakisasaki/autoware.universe that referenced this pull request Feb 12, 2025
@sasakisasaki sasakisasaki marked this pull request as ready for review February 13, 2025 00:17
@sasakisasaki sasakisasaki changed the title Feat porting motion utils from universe to core feat: porting autoware_motion_utils from universe to core Feb 13, 2025
mitsudome-r pushed a commit to autowarefoundation/autoware.universe that referenced this pull request Feb 13, 2025
porting(autoware_motion_utils): port to `autoware.core/common`

  * Related PR:
      autowarefoundation/autoware.core#184

Signed-off-by: Junya Sasaki <[email protected]>
@mitsudome-r mitsudome-r merged commit d48c0ff into autowarefoundation:main Feb 13, 2025
35 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants