updated Horizon API calls to match Omnissa changes

[smaddock]

Tested and working. Note the version variable value also changed to be just the number.

[randomName0815]

Hi, fails for me at CodeSignatureVerifier, input_path has the old pkg name.
<string>%pathname%/VMware Horizon Client.pkg</string>
should be
<string>%pathname%/Omnissa Horizon Client.pkg</string>

btw. this needs some more changes in other repos/recipes

[smaddock]

Not sure how I missed that. Updated commit.

[randomName0815]

thanks, looks good to me
added PR for pkg recipe autopkg/rtrouton-recipes#206

[dev-yeet]

not sure the correct way to go about this, but I submitted a pull request to your repo @smaddock to update the munki recipe that will depend on this pull request. I also added some additional Omnissa rebranding changes including renaming the folder and recipe file names

[smaddock]

Changing the filenames and recipe identifiers will break existing dependencies with no indication of why. It is of course up to the maintainers of this repo, but I would suggest instead adding new recipes with the new name, and adding a deprecation notice to this one advising people to switch, which will keep recipes working while providing a path forward.

[paul-cossey]

My vote would be new recipes for Omnissa Horizon Client, and deprecate the VMware ones.

I also don't think @scriptingosx is particularly active with AutoPkg these days, so may welcome another interested party taking over the maintenance?

[paul-cossey]

I added some based off this PR and the Munki recipe: https://github.com/autopkg/dataJAR-recipes/tree/master/Omnissa%20Horizon%20Client

[smaddock]

Added a deprecation notice to my PR, and then noticed @paul-cossey made a better PR. :) Going to close this one.