Fix custom transaction error code clash, and make ethereum tests easier to write #3359
+200
−171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
requested review from
NingLin-P,
vedhavyas and
nazar-pc
as code owners
teor2345
force-pushed
the
private-evm-prep
branch
from
98cbdd1 to
1fc8774
Compare
teor2345
force-pushed
the
private-evm-prep
branch
from
1fc8774 to
79b4863
Compare
This was referenced Jan 28, 2025
vedhavyas
previously approved these changes
Jan 28, 2025
domains/runtime/evm/Cargo.toml
Outdated
| @@ -21,6 +21,7 @@ codec = { package = "parity-scale-codec", version = "3.6.12", default-features = | |||
| domain-check-weight = { version = "0.1.0", path = "../../pallets/domain-check-weight", default-features = false } | |||
| domain-pallet-executive = { version = "0.1.0", path = "../../pallets/executive", default-features = false } | |||
| domain-runtime-primitives = { version = "0.1.0", path = "../../primitives/runtime", default-features = false } | |||
| # just here to activate the serde feature | |||
There was a problem hiding this comment.
can't we just enable this feature through the primitives here ?
The comment is confusing without context
There was a problem hiding this comment.
I tried that yesterday and it didn’t work. I’ll have another go today.
vedhavyas
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to review this PR
This PR is the first in a series of PRs which add "private EVM" functionality to subspace. It moves some code around and makes minor fixes.
The second PR in the series implements the private EVM feature, it is #3350.
The third PR in the series is #3360, it applies a storage migration to the Taurus runtime. (This storage isn't currently deployed on mainnet, so a migration isn't needed there.)
What it does
test-ethereumfeatureCode contributor checklist: